[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

[Qing Shan Zhang via Phabricator via cfe-commits]

steven.zhang added inline comments.


================
Comment at: clang/lib/Basic/Targets/PPC.cpp:272
                             .Default(false);
 
   Features["qpx"] = (CPU == "a2q");
----------------
Do we miss to define this macro ?
```
 __POWER10_VECTOR__
```


================
Comment at: llvm/lib/Target/PowerPC/PPC.td:211
+                                     "true",
+                                     "Enable instructions added in ISA 3.1.">;
 def FeatureP9Altivec : SubtargetFeature<"power9-altivec", "HasP9Altivec", 
"true",
----------------
Nit: no ending dot.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80020/new/

https://reviews.llvm.org/D80020



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits