sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land.
Thanks! ================ Comment at: clang-tools-extra/clangd/Diagnostics.cpp:127 // We only report diagnostics with at least error severity from headers. - if (D.Severity < DiagnosticsEngine::Level::Error) + // Note that we only use the default serverity to avoid adding too much noise, + // especially there is a "-Werror" flag in the compile command. ---------------- "especially" suggests there are other cases where we we report non-default errors, but I'm not sure there are. Maybe just "Use default severity to avoid noise with -Werror". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79923/new/ https://reviews.llvm.org/D79923 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
