martong added a comment.

Would it be possible to split this patch into two?

1. The refactoring part where you move code out from checkPreStmt to checkVLA. 
This should be an NFC.
2. Handling of the overflow.

Would be much cleaner I guess.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79330/new/

https://reviews.llvm.org/D79330



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to