rengolin accepted this revision. rengolin added a reviewer: rengolin. rengolin added a comment. This revision is now accepted and ready to land.
Hi Sam, The patch looks good, thanks! A few comments on the process: 1. When you send an update, send the whole patch again, not just the new diff. Either squash or diff master, doesn't matter. If you don't have commit access, people will have to download the patch from this page to commit, and they'll need the whole change set. 2. When you commit, don't commit the requested changes in separate. If the patch makes sense as one commit, it'll still need to be one commit after all code review changes. So, a git rebase squash will be necessary to bring the number of patches down to the original list before git svn dcommit. 3. When you send a patch to review on Phab, please use "git show -U999", so that the patch is uploaded with context. I wish Phab was smart enough to know where the patch is being applied to and checkout the context from git/SVN, but apparently, it isn't. You can help by showing the context via -U option. If you don't have commit rights, please upload the full patch to this review again, so I can commit it all at once. cheers, --renato http://reviews.llvm.org/D18311 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
