Welcome to my another idea to improve RangeConstraintManager? 
https://reviews.llvm.org/D78933


________________________________
Denys Petrov
Senior С++ Developer | Kharkiv, Ukraine

________________________________
От: Balazs Benics via Phabricator <revi...@reviews.llvm.org>
Отправлено: 10 апреля 2020 г. 15:53
Кому: benicsbal...@gmail.com; noqnoq...@gmail.com; adam.bal...@ericsson.com; 
dabis.csab...@gmail.com; dkszelet...@gmail.com
Копия: richard.sza...@ericsson.com; xazax....@gmail.com; 
peterszecs...@gmail.com; rekanikol...@gmail.com; a.sido...@samsung.com; 
mikhail.rama...@gmail.com; donat.n...@ericsson.com; daniel.kr...@ericsson.com; 
martongab...@gmail.com; Denis Petrov; cfe-commits@lists.llvm.org; 
mlek...@skidmore.edu; blitzrak...@gmail.com; shen...@google.com; 
1.in...@gmail.com
Тема: [PATCH] D77792: [analyzer] Extend constraint manager to be able to 
compare simple SymSymExprs

CAUTION: This email originated from outside of the organization. Do not click 
links or open attachments unless you recognize the sender and know the content 
is safe.  If you suspect potential phishing or spam email, report it to 
reports...@accesssoftek.com

steakhal updated this revision to Diff 256551.
steakhal added a comment.

- rewritten the `RangeSet::compare` function and checked the assumptions on 
WolframAlpha
- moved the `RangeSet::compare` function to a cpp file
- added comments to the `RangeSet::compare` function
- fixed the comment in `RangeConstraintManager::canReasonAbout` function
- introduced the `RangeSet::CompareResult::identical` enum value to be complete
- updated the `RangeConstraintManager::tryAssumeSymSymOp` accoding the 
`identical` CompareResult.
- omited testing the `[2,5] < [5,10]` testcase, since that is covered by `[0,5] 
< [5,10]`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77792/new/

https://reviews.llvm.org/D77792

Files:
  
clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h
  clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp
  clang/lib/StaticAnalyzer/Core/RangedConstraintManager.cpp
  clang/test/Analysis/constraint-manager-sym-sym.c

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to