davezarzycki added a comment. In D75068#2004885 <https://reviews.llvm.org/D75068#2004885>, @cristian.adam wrote:
> In D75068#2004072 <https://reviews.llvm.org/D75068#2004072>, @davezarzycki > wrote: > > > Rather than wholly reverting this, I committed a fix: > > 665471907a5c072c6653a38c35f35e5d54cef220 > > <https://reviews.llvm.org/rG665471907a5c072c6653a38c35f35e5d54cef220> > > > > The problem is that "NOT LIBCLANG_BUILD_STATIC" does not imply PIC, so > > there is no point in trying to build the SHARED version. Please let me know > > if I somehow missed something. Thanks! > > > @thakis has a use case at https://reviews.llvm.org/D74907 building a SHARED > libclang with `LLVM_ENABLE_PIC` set to `OFF`. > > Would the variant `if(LLVM_ENABLE_PIC OR (WIN32 AND NOT > LIBCLANG_BUILD_STATIC))` work for the Fedora case? Fedora is not WIN32, so sure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75068/new/ https://reviews.llvm.org/D75068 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
