kadircet added inline comments.
================
Comment at: clang/lib/Lex/PPDirectives.cpp:2070
+ diag::err_pp_including_mainfile_in_preamble);
+ return {ImportAction::None};
+ }
----------------
Instead of returning here I think we should set the Action to `Skip`. So that
relevant callbacks (`InclusionDirective` and `FileSkipped`) is invoked. (maybe
have a test for that too?)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78366/new/
https://reviews.llvm.org/D78366
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
