On Wed, Mar 16, 2016 at 11:38 AM, don hinton via cfe-commits < cfe-commits@lists.llvm.org> wrote:
> hintonda updated this revision to Diff 50843. > hintonda added a comment. > > Added FIXME comment, and reformated with clang-format. > > > http://reviews.llvm.org/D18123 > > Files: > include/clang/AST/UnresolvedSet.h > include/clang/Sema/Lookup.h > > Index: include/clang/Sema/Lookup.h > =================================================================== > --- include/clang/Sema/Lookup.h > +++ include/clang/Sema/Lookup.h > @@ -185,6 +185,11 @@ > Shadowed(false) > {} > > + // FIXME: These deleted methods can be removed once the default build > includes > + // both -Werror and -Wdeprecated. > I wouldn't worry about the default build being -Werror. It's an option, we keep the build warning clean (we do that by many of us using -Werror, but it's not necessary as such - some buildbots us it too (-Wunused flags often enough)). So if you could drop that clause (just leave it as "removed once the default build uses -Wdeprecated", perhaps?) After taht, please go ahead & commit without the need for another round of review or anything. > + LookupResult(const LookupResult &) = delete; > + LookupResult &operator=(const LookupResult &) = delete; > + > ~LookupResult() { > if (Diagnose) diagnose(); > if (Paths) deletePaths(Paths); > Index: include/clang/AST/UnresolvedSet.h > =================================================================== > --- include/clang/AST/UnresolvedSet.h > +++ include/clang/AST/UnresolvedSet.h > @@ -59,8 +59,11 @@ > // UnresolvedSet. > private: > template <unsigned N> friend class UnresolvedSet; > - UnresolvedSetImpl() {} > - UnresolvedSetImpl(const UnresolvedSetImpl &) {} > + UnresolvedSetImpl() = default; > + UnresolvedSetImpl(const UnresolvedSetImpl &) = default; > + UnresolvedSetImpl(UnresolvedSetImpl &&) = default; > + UnresolvedSetImpl &operator=(const UnresolvedSetImpl &) = default; > + UnresolvedSetImpl &operator=(UnresolvedSetImpl &&) = default; > > public: > // We don't currently support assignment through this iterator, so we > might > > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits > >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
