sdesmalen marked an inline comment as done.
sdesmalen added a comment.

In D78239#1987859 <https://reviews.llvm.org/D78239#1987859>, @efriedma wrote:

> I think the predicate type is something we should fix.   Even if it's not 
> causing problems now, it seems like the sort of thing that will bite us later.


Yes I agree, I've implemented this in D78402 <https://reviews.llvm.org/D78402>



================
Comment at: clang/utils/TableGen/SveEmitter.cpp:1035
+  OS << "#define svcvtxnt_f32_x     svcvtxnt_f32_m\n";
+  OS << "#define svcvtxnt_f32_f64_x svcvtxnt_f32_f64_m\n\n";
+
----------------
efriedma wrote:
> Not worth implementing these separately?  I guess I can see why it wouldn't 
> be profitable.
We currently don't really optimise the _x (MergeAny) case yet for other 
intrinsics, so addressing this seems more trouble than it's worth, specifically 
because the merging with `undef` for only the top/odd lanes would not be 
trivial to represent. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78239/new/

https://reviews.llvm.org/D78239



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to