miscco added inline comments.

================
Comment at: clang/include/clang/Sema/DeclSpec.h:416
   static bool isTypeRep(TST T) {
-    return (T == TST_typename || T == TST_typeofType ||
-            T == TST_underlyingType || T == TST_atomic);
+    return (TST_typename <= T <= TST_atomic);
   }
----------------
There is a bug here, this should probably be

```
return (TST_typename <= T && T <= TST_atomic);
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67052/new/

https://reviews.llvm.org/D67052



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D6705... Michael Schellenberger Costa via Phabricator via cfe-commits
    • [PATCH] ... Zoe Carver via Phabricator via cfe-commits
    • [PATCH] ... Zoe Carver via Phabricator via cfe-commits
    • [PATCH] ... Zoe Carver via Phabricator via cfe-commits

Reply via email to