rjmccall added a comment. In D76384#1986761 <https://reviews.llvm.org/D76384#1986761>, @mibintc wrote:
> In D76384#1986525 <https://reviews.llvm.org/D76384#1986525>, @mibintc wrote: > > > @rjmccall Can you check the patch added last night here, commit > > 3ee1ec0b9dd6ee2350f39ae8a418bf3ce28d06cf > > <https://reviews.llvm.org/rG3ee1ec0b9dd6ee2350f39ae8a418bf3ce28d06cf> > > Author: Benjamin Kramer <benny....@googlemail.com> > > Date: Thu Apr 16 11:45:02 2020 +0200 > > > > LangOptions cannot depend on ASTContext, make it not use ASTContext > > directly > > > > Fixes a layering violation introduced in > > 2ba4e3a4598b165245c581c506a813cd4a7dce33. > > > > > I checked Benny's patch and it seems to have all the right semantics. The lit > tests pass and the trailing storage is only created in the pragma case. Looks good to me, too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/ https://reviews.llvm.org/D76384 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
