MaskRay added inline comments.
================
Comment at: clang-tools-extra/modularize/PreprocessorTracker.cpp:912
// Lookup/add string.
- StringHandle addString(llvm::StringRef Str) { return Strings.intern(Str); }
+ StringHandle addString(llvm::StringRef Str) {
+ return Strings.insert(Str).first->first();
----------------
Is it well-known that a StringSet (= `StringMap<NoneType, ...>`) returned
StringRef is stable? Is that property something we can reliably depend on?
If not, StringSaver.h:UniqueStringSaver may be a better choice.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78273/new/
https://reviews.llvm.org/D78273
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
