sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang-tools-extra/clangd/Headers.h:55 + Range R; // Inclusion range. + std::string Directive; // Directive used for inclusion, e.g. import + std::string Written; // Inclusion name as written e.g. <vector>. ---------------- nit: why not store as tok::PPKeywordKind? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78235/new/ https://reviews.llvm.org/D78235 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits