kbobyrev marked an inline comment as done.
kbobyrev added inline comments.
================
Comment at: clang-tools-extra/clangd/CMakeLists.txt:194
+
+ add_definitions(-DGOOGLE_PROTOBUF_NO_RTTI=1)
+ include_directories(${Protobuf_INCLUDE_DIRS})
----------------
sammccall wrote:
> these global side-effects are pretty scary, can we limit them somehow?
I'll be using `target_compile_definitions()` manually then. Not sure if it's
much better (since users would have to manually add those defines), maybe if
there are more protos in the future it'd be better to add function for setting
up the target which will be linked against generated protobufs.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77794/new/
https://reviews.llvm.org/D77794
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
