MarcusJohnson91 added a comment. @MyDeveloperDay
> but I'm also constantly surprised by how many of the enumeration cases > started out as booleans only later to have to be converted to enums. The more > I think about this the more I think the problem can probably be dealt with > better by making it an enumeration. (even if you support true and false to > mean "indent" and "don't indent" I FULLY support all new options being required to be enums from now on, bools cause a whole lotta trouble when they have to be changed. I've rewritten my patch, it works when manually testing it, now I'm just working on the automated tests. A brand new patch should be up by either tonight or tomorrow. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
