dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land.
LGTM. ================ Comment at: llvm/unittests/Support/MemoryBufferTest.cpp:396 + + auto MBOrError = MemoryBuffer::getOpenFile(FD, TestPath, -1, false, true); + ASSERT_NO_ERROR(MBOrError.getError()) ---------------- Maybe add named arguments in comments for the last three? They're a bit inscrutable, and the whole point is to test `IsVolatile`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77772/new/ https://reviews.llvm.org/D77772 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
