dexonsmith added a comment. In D70284#1752893 <https://reviews.llvm.org/D70284#1752893>, @bendjones wrote:
> In D70284#1752811 <https://reviews.llvm.org/D70284#1752811>, @dexonsmith > wrote: > > > For some reason this revision is locked down and I'm not allowed to "edit" > > it, which includes adding inline review comments. Can you add me as a > > reviewer? > > > Thought I did. I'm still not able to edit this, so I cannot "accept revision". I'm not sure what's going wrong but this revision object seems corrupted. >> The two comments: >> >> - Please add a period at the end of the sentence in the comment. > > Will do. The comment actually looks liable to bitrot, since IIUC it's talking about callers which can change over time. LGTM if you remove it. >> - Can you give more context about what `objc_arc_inert` is doing, and why >> it's necessary now that `no_dead_strip` is gone? > > The objc_arc_inert was added to other similar things so in the spirt of > making things match I added it here. I can keep it simple though. Okay, SGTM. There are no ARC operations, and this will allow certain optimizations. I suggest documenting why it's safe in the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70284/new/ https://reviews.llvm.org/D70284 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
