morehouse added inline comments.

================
Comment at: clang/tools/clang-fuzzer/ClangObjectiveCFuzzer.cpp:19
 
-extern "C" int LLVMFuzzerInitialize(int *argc, char ***argv) { return 0; }
-
----------------
RKSimon wrote:
> @dgoldman @morehouse Removing this has been causing link failures ever since 
> it was committed on a number of targets including msvc (PR44414) and I've 
> just noticed it on a linux release+asserts build. If it is superfluous why 
> did you leave it in ClangFuzzer.cpp ?
It is superfluous on Linux at least since libFuzzer defines its own weak 
definition.  I'm not sure how it works for Windows.

I'm fine if you want to add it back in here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69171/new/

https://reviews.llvm.org/D69171



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D69171: [clang-fuzz... Simon Pilgrim via Phabricator via cfe-commits
    • [PATCH] D69171: [clang... Matt Morehouse via Phabricator via cfe-commits

Reply via email to