kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
Thanks for remembering this :D LGTM!
================
Comment at: clang-tools-extra/clangd/JSONTransport.cpp:28
+ [&](const CancelledError &C) -> llvm::Error {
+ switch (C.Reason) {
+ case static_cast<int>(ErrorCode::ContentModified):
----------------
Maybe `static_cast<ErrorCode>(C.Reason)` instead of casting cases.
I know the reason is not necessarily LSP specific, but we seem to be defaulting
to `ErrorCode::RequestCancelled` anyways.
================
Comment at: clang-tools-extra/clangd/JSONTransport.cpp:29
+ switch (C.Reason) {
+ case static_cast<int>(ErrorCode::ContentModified):
+ Code = ErrorCode::ContentModified;
----------------
please fix
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77947/new/
https://reviews.llvm.org/D77947
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
