mehdi_amini added inline comments.
================ Comment at: llvm/include/llvm/Support/GenericDomTree.h:32 #include "llvm/ADT/SmallVector.h" +#include "llvm/IR/CFGDiff.h" #include "llvm/Support/CFGUpdate.h" ---------------- mehdi_amini wrote: > dblaikie wrote: > > mehdi_amini wrote: > > > This looks like a layering violation to me here: I wouldn't expect a > > > generic utility in Support to introduce a dependency on IR. > > > > > > I speculatively reverted in > > > https://github.com/llvm/llvm-project/commit/57d2d48399b63c0ef1dda490fdaf28efbb80c2c0 > > > while we can figure it out. > > Yep - agreed on the layering violation. Thanks for the catch/revert! > > > > I /think/ CFGDiff.h is independent of IR & shouldn't include IR/CFG.h and > > then can move into Support. Ah, yeah, when I did > > 30804d0a3fb23325c4b455108e59d00213b83891 & related work, that's what made > > it independent of IR. > > > > Moved it over to Support in a838aadae3f20b9644e2ad553d3d558a91fd8fd7 > Thanks! Re-landed in 0445c64998d14b81f0d3a3182011fc5eae47fa71 Actually reverted again as it breaks the MLIR build in a different way, I won't be able to look into this in more details right now. (I ran `ninja check` but I forgot that `check` is not `check-all`...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77341/new/ https://reviews.llvm.org/D77341 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
