morehouse requested changes to this revision. morehouse added a comment. This revision now requires changes to proceed.
In D63616#1961449 <https://reviews.llvm.org/D63616#1961449>, @tuktuk wrote: > Am I missing an additional step for test integration, after adding the test > file? Just tried locally and I think you need to rename to file from *.cc to *.cpp. Then it will run during `ninja check-sanitizer`. I did that and the test fails for me. -- Exit Code: 1 Command Output (stderr): -- Expected 14 lines, got 28. -- Please take a look and fix it. ================ Comment at: compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_whitelist_blacklist.cc:8 + +// RUN: echo -e "src:*\nfun:*" > wl_all.txt +// RUN: echo -e "" > wl_none.txt ---------------- Please use `%t` or `%T` in temp file names so that they get cleaned up properly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63616/new/ https://reviews.llvm.org/D63616 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
