dim added a comment. In D77776#1971543 <https://reviews.llvm.org/D77776#1971543>, @arichardson wrote:
> Alternatively, the checks could be changed to also handle OSMajorVersion == 0 > and translate that to 10. > This seems to be what NetBSD.cpp does. Darwin.cpp also infers the version > from the host when running on macos. Yeah, I think that is much better. If people want to explicitly target foobar-freebsd9, they should be free to do so. But the default should indeed be either the host version, or if that cannot be determined, the lowest supported version, which is currently 10. For these particular features the exact version doesn't matter that much though, it's just about whether libc++ should be the default. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77776/new/ https://reviews.llvm.org/D77776 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
