dblaikie added a comment. In D68049#1971276 <https://reviews.llvm.org/D68049#1971276>, @MaskRay wrote:
> In D68049#1970825 <https://reviews.llvm.org/D68049#1970825>, @tmsriram wrote: > > > Ping. > > > @rsmith ^^^ > > More specific question, do you think > `clang/test/CodeGen/basicblock-sections.c` should be converted to a `-S > -emit-llvm` test? My understanding is that because this patch only changes TargetOptions, it has no effect on the emitted LLVM IR - only on how that IR is translated to machine code. (like -ffunction-sections, for instance - that property is not persisted in the LLVM IR, it's an API-level communication between Clang and the LLVM backends) So either it goes untested, or it gets tested by a source->assembly test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68049/new/ https://reviews.llvm.org/D68049 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
