Xiangling_L added inline comments.
================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:4205
+
+class PPCAIX32TargetCodeGenInfo : public TargetCodeGenInfo {
+public:
----------------
sfertile wrote:
> Xiangling_L wrote:
> > I have a question here. AIX32 falls into PPC32 target, so why we don't
> > inherit from `PPC32TargetCodeGenInfo` instead?
> Do we need a separate AIX specific class? We are implementing 2 functions, 1
> of which is the same implementation as its `PPC32TargetCodeGenInfo`
> counterpart. If we have access to the triple, we can return true when the OS
> is AIX in `PPC32TargetCodeGenInfo::initDwarfEHRegSizeTable`. With the
> implementations being nearly identical (and after enabling
> DwarfEHRegSizeTable they will be identical) I think we are better to not add
> a new class if we can avoid it.
Not adding a new class makes sense to me if we are sure that
`DwarfEHRegSizeTable` will be identical/viable for AIX.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76360/new/
https://reviews.llvm.org/D76360
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
