Re: [PATCH] D18271: Avoid -Wshadow warnings about constructor parameters named after fields

[David Blaikie via cfe-commits]

dblaikie added a subscriber: dblaikie.
dblaikie added a comment.

It's not just modifications of shadowed variables that are a problem - one of 
the one's I'm concerned we should catch is:

  struct foo {
    std::unique_ptr<int> p;
    foo(std::unique_ptr<int> p) : p(std::move(p)) {
      f(*p);
    }
  };


http://reviews.llvm.org/D18271



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits