sammccall added a comment.

In D77507#1964309 <https://reviews.llvm.org/D77507#1964309>, @vabridgers wrote:

> Thank you for the comments. I'll keep looking at this to find a proper fix, 
> but any hints you may have would be greatly appreciated (debugging tips, 
> strategies, areas of code to focus on). This code is new to me, so I may not 
> be as efficient at tracking this down as yourself or Ilya. Best!


Hope you don't mind, I ended up writing up a fix myself. (Well, I got 
frustrated with TokenBuffer's internals being complicated, and rewrote some of 
it in a way that makes this bug easy to fix.) D77615 
<https://reviews.llvm.org/D77615> is the proposed fix for this bug, and D77614 
<https://reviews.llvm.org/D77614> is the required refactoring.

FWIW I don't have much great advice about debugging this stuff beyond 
minimizing the example as far as possible and instrumenting with lots of 
printfs...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77507/new/

https://reviews.llvm.org/D77507



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to