ABataev added inline comments.
================ Comment at: clang/lib/Sema/SemaOpenMP.cpp:17001-17038 + // target, target data + // OpenMP 5.0 [2.12.2, Restrictions, p. 163] + // OpenMP 5.0 [2.12.5, Restrictions, p. 174] + // A map-type in a map clause must be to, from, tofrom or alloc + if ((DKind == OMPD_target || DKind == OMPD_target_data || + DKind == OMPD_target_parallel || DKind == OMPD_target_parallel_for || + DKind == OMPD_target_parallel_for_simd || ---------------- 1. Why 2 similar checks? 2. Some of the logical conditions can be replaced with `isOpenMPTagetExecutableDirective()` or similar. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77581/new/ https://reviews.llvm.org/D77581 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
