hubert.reinterpretcast added inline comments.

================
Comment at: clang/docs/UsersManual.rst:1684
+   linkage symbols. The unique name is obtained by appending the hash of the
+   full module name to the original symbol. This option is particularly useful
+   in attributing profile information to the correct function when multiple
----------------
MaskRay wrote:
> rnk wrote:
> > I think it's important to be specific here. I'd go so far as to say:
> > "When this option is set, compiler hashes the main source file path from 
> > the command line and appends it to all internal symbols. If a program 
> > contains multiple objects compiled from the same source file path, the 
> > symbols are not guaranteed to be unique."
> Should option like -ffile-prefix-map= affect the hashed source file path? I 
> suspect it already does this but I haven't verified.
> 
> This may need tests for Windows and non-Windows, similar to D77223.
With respect to @rnk's suggestion, "from the same source file path" implies the 
same file. I would suggest saying "with the same command-line source file 
specification".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73307/new/

https://reviews.llvm.org/D73307



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to