njames93 marked 9 inline comments as done.
njames93 added inline comments.
================
Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:294
+ if (isa<CXXMethodDecl>(FD) && cast<CXXMethodDecl>(FD)->isStatic())
+ DeleteKeyword(tok::kw_static, {FD->getBeginLoc(), FD->getLocation()});
----------------
kadircet wrote:
> sorry if I miscommunicated, I was trying to say that multiple `static`
> keywords are also allowed by clang. So we should be dropping all of them, as
> we do for `virtual`
Yeah sorry, I checked and it was rejected. I just realised I was checking
against gcc...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77534/new/
https://reviews.llvm.org/D77534
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
