NoQ added inline comments.

================
Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:127
+      const auto *Init = ICC->getCXXCtorInitializer();
+      return getObjectUnderConstruction(State, Init, LCtx);
+    }
----------------
NoQ wrote:
> baloghadamsoftware wrote:
> > This does not find anything in the map for base initializers.
> Yup, that's because they're not handled through the 
> objects-under-construction map. See `ExprEngine::handleConstructor()` - the 
> switch on constructor kinds.
> 
> That said, i don't think you need to look it up from the map; just re-compute 
> the region instead exactly how `ExprEngine::handleConstructor()` does it.
(this should be easier because it'll be exactly one line of code here, assuming 
the common part is factored out from `handleConstructor()`)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77229/new/

https://reviews.llvm.org/D77229



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to