sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thank you!
================
Comment at:
clang-tools-extra/test/clang-tidy/checkers/fuchsia-multiple-inheritance.cpp:48
// Inherits from multiple concrete classes.
-// CHECK-MESSAGES: [[@LINE+2]]:1: warning: inheriting mulitple classes that
aren't pure virtual is discouraged [fuchsia-multiple-inheritance]
+// CHECK-MESSAGES: [[@LINE+2]]:1: warning: inheriting multiple classes that
aren't pure virtual is discouraged [fuchsia-multiple-inheritance]
// CHECK-NEXT: class Bad_Child1 : public Base_A, Base_B {};
----------------
Did you update the actual generated diagnostic in
clang-tidy/fuchsia/MultipleInheritanceCheck.cpp? I don't see it in this patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77458/new/
https://reviews.llvm.org/D77458
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
