hliao marked an inline comment as done. hliao added inline comments.
================ Comment at: clang/test/SemaCUDA/bad-attributes.cu:74-75 + +typedef __attribute__((device_builtin_surface_type)) unsigned long long s0_ty; // expected-warning {{'device_builtin_surface_type' attribute only applies to classes}} +typedef __attribute__((device_builtin_texture_type)) unsigned long long t0_ty; // expected-warning {{'device_builtin_texture_type' attribute only applies to classes}} + ---------------- tra wrote: > Please add few test cases replicating use of these attributes in CUDA headers. the replication from CUDA headers is added on those codegen tests. These tests are illegal ones which sema checks should identify. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76948/new/ https://reviews.llvm.org/D76948 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits