sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land.
In D76770#1943077 <https://reviews.llvm.org/D76770#1943077>, @hokein wrote: > yes, it has a regression, but we don't change the behavior for the above > case. A regression case is like Oops, right :-) >> Or we can take the tradeoff here if it's better but it'd be good to >> understand why. > > it was originally reported by one internal user. > > I think the new behavior (with this patch) > > - is more aligned with mental model of code completion (most people think > code completion just inserts the code text at the cursor position ) > - keeps the consistent behavior with other code completions, e.g. > `foo.^member()` if you select the `member` in code completion, another > `member` text will be inserted OK, let's try it and see if people complain. (There's also an argument for only replacing the text on the left of the cursor, that's more consistent with completion in general though I think less helpful too) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76770/new/ https://reviews.llvm.org/D76770 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
