sdesmalen added a comment. In D76617#1938787 <https://reviews.llvm.org/D76617#1938787>, @SjoerdMeijer wrote:
> Patches with functional changes but without tests are a bit "suspicious". In > this case, I see it might be tricky. You could argue that it should be > incorporated in the patch that includes the tests, so we can see what's > happening. But perhaps separating this out is cleaner, if the other patch is > big. But can you at least make the next patch dependent on this one, so we > know where this is used? Yes you're right, the patch that I've made dependent needs this one to work properly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76617/new/ https://reviews.llvm.org/D76617 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
