rsandifo-arm created this revision.
rsandifo-arm added reviewers: sdesmalen, efriedma, rovka, rjmccall.
Herald added subscribers: cfe-commits, psnobl, rkruppe, tschuett.
Herald added a reviewer: rengolin.
Herald added a project: clang.
rsandifo-arm added a child revision: D76692: [AST][SVE] Treat built-in SVE
types as trivial.
SVE types are trivially copyable: they can be copied simply
by reproducing the byte representation of the source object.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D76691
Files:
clang/lib/AST/Type.cpp
clang/test/SemaCXX/sizeless-1.cpp
Index: clang/test/SemaCXX/sizeless-1.cpp
===================================================================
--- clang/test/SemaCXX/sizeless-1.cpp
+++ clang/test/SemaCXX/sizeless-1.cpp
@@ -489,6 +489,7 @@
(void)typeid(ref_int8);
(void)typeid(static_int8_ptr);
+ _Static_assert(__is_trivially_copyable(svint8_t), "");
_Static_assert(__is_trivially_destructible(svint8_t), "");
_Static_assert(!__is_nothrow_assignable(svint8_t, svint8_t), "");
_Static_assert(__is_nothrow_assignable(svint8_t &, svint8_t), "");
@@ -602,9 +603,7 @@
for (const svint8_t &x : wrapper<svint8_t>()) { // expected-warning {{loop
variable 'x' binds to a temporary value produced by a range of type
'wrapper<svint8_t>'}} expected-note {{use non-reference type}}
(void)x;
}
- // This warning is bogus and will be removed by a later patch.
- // The point is to show that it's being removed for the right reasons.
- for (const svint8_t x : wrapper<const svint8_t &>()) { // expected-warning
{{loop variable 'x' creates a copy from type 'const svint8_t'}} expected-note
{{use reference type}}
+ for (const svint8_t x : wrapper<const svint8_t &>()) {
(void)x;
}
#endif
Index: clang/lib/AST/Type.cpp
===================================================================
--- clang/lib/AST/Type.cpp
+++ clang/lib/AST/Type.cpp
@@ -2318,6 +2318,9 @@
if (CanonicalType->isDependentType())
return false;
+ if (CanonicalType->isSizelessBuiltinType())
+ return true;
+
// Return false for incomplete types after skipping any incomplete array
types
// which are expressly allowed by the standard and thus our API.
if (CanonicalType->isIncompleteType())
Index: clang/test/SemaCXX/sizeless-1.cpp
===================================================================
--- clang/test/SemaCXX/sizeless-1.cpp
+++ clang/test/SemaCXX/sizeless-1.cpp
@@ -489,6 +489,7 @@
(void)typeid(ref_int8);
(void)typeid(static_int8_ptr);
+ _Static_assert(__is_trivially_copyable(svint8_t), "");
_Static_assert(__is_trivially_destructible(svint8_t), "");
_Static_assert(!__is_nothrow_assignable(svint8_t, svint8_t), "");
_Static_assert(__is_nothrow_assignable(svint8_t &, svint8_t), "");
@@ -602,9 +603,7 @@
for (const svint8_t &x : wrapper<svint8_t>()) { // expected-warning {{loop variable 'x' binds to a temporary value produced by a range of type 'wrapper<svint8_t>'}} expected-note {{use non-reference type}}
(void)x;
}
- // This warning is bogus and will be removed by a later patch.
- // The point is to show that it's being removed for the right reasons.
- for (const svint8_t x : wrapper<const svint8_t &>()) { // expected-warning {{loop variable 'x' creates a copy from type 'const svint8_t'}} expected-note {{use reference type}}
+ for (const svint8_t x : wrapper<const svint8_t &>()) {
(void)x;
}
#endif
Index: clang/lib/AST/Type.cpp
===================================================================
--- clang/lib/AST/Type.cpp
+++ clang/lib/AST/Type.cpp
@@ -2318,6 +2318,9 @@
if (CanonicalType->isDependentType())
return false;
+ if (CanonicalType->isSizelessBuiltinType())
+ return true;
+
// Return false for incomplete types after skipping any incomplete array types
// which are expressly allowed by the standard and thus our API.
if (CanonicalType->isIncompleteType())
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
