MyDeveloperDay added inline comments.

================
Comment at: clang/unittests/Format/FormatTest.cpp:2468
                "}");
-  verifyFormat("extern \"C\" int foo() {}");
-  verifyFormat("extern \"C\" int foo();");
-  verifyFormat("extern \"C\" int foo() {\n"
+  verifyFormat("extern \"C\" int FormatsExternC_2() {}");
+  verifyFormat("extern \"C\" int FormatsExternC_3();");
----------------
I know why you change these varaibles becuase when your developing its hard to 
see which test is failing because verifyFormat doesn't report the correct file 
and line number

but I like the use of `foo` because its 1 character more than your indent width 
and if there is going to be an out by one error you might hide it with a longer 
name


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75791/new/

https://reviews.llvm.org/D75791



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to