tbaeder marked an inline comment as done. tbaeder added a comment. Thanks, I'll take a look at the tests.
================ Comment at: clang/test/SemaCXX/switch-implicit-fallthrough.cpp:110-114 + case 26: + return 0; + __attribute__((fallthrough)); // expected-warning{{fallthrough annotation in unreachable code}} + case 27: + break; ---------------- aaron.ballman wrote: > This test seems unrelated to the patch, or am I misunderstanding something? This is the test that prompted me to write this patch - before this patch, the error message has an invalid loc. I guess I should remove this here and move it over to the source ranges tests and also test that is has the right source range. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75844/new/ https://reviews.llvm.org/D75844 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits