martong added inline comments.
================
Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:152
+ break;
+ default:
+ llvm_unreachable("Unknown RangeConstraint kind!");
----------------
martong wrote:
> This `default` branch is not needed here (actually gives a compiler warning
> too).
> This default branch is not needed here (actually gives a compiler warning
> too).
I am not sure why I thought that that's not needed, actually we need that.
(Perhaps an intermediate version returned in each cases.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73898/new/
https://reviews.llvm.org/D73898
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
