This revision was automatically updated to reflect the committed changes. erichkeane marked 2 inline comments as done. Closed by commit rG661c950630fb: [NFC][Attr TableGen] Emit Spelling Enum for Attr types if there >1 (authored by erichkeane). Herald added a project: clang.
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76289/new/ https://reviews.llvm.org/D76289 Files: clang/utils/TableGen/ClangAttrEmitter.cpp Index: clang/utils/TableGen/ClangAttrEmitter.cpp =================================================================== --- clang/utils/TableGen/ClangAttrEmitter.cpp +++ clang/utils/TableGen/ClangAttrEmitter.cpp @@ -2329,7 +2329,7 @@ SemanticSpellingMap SemanticToSyntacticMap; std::string SpellingEnum; - if (!ElideSpelling) + if (Spellings.size() > 1) SpellingEnum = CreateSemanticSpellings(Spellings, SemanticToSyntacticMap); if (Header) OS << SpellingEnum;
Index: clang/utils/TableGen/ClangAttrEmitter.cpp =================================================================== --- clang/utils/TableGen/ClangAttrEmitter.cpp +++ clang/utils/TableGen/ClangAttrEmitter.cpp @@ -2329,7 +2329,7 @@ SemanticSpellingMap SemanticToSyntacticMap; std::string SpellingEnum; - if (!ElideSpelling) + if (Spellings.size() > 1) SpellingEnum = CreateSemanticSpellings(Spellings, SemanticToSyntacticMap); if (Header) OS << SpellingEnum;
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits