oontvoo marked an inline comment as done.
oontvoo added inline comments.
================
Comment at: clang/lib/Lex/HeaderSearch.cpp:1266
+ if (PP.isIncludeVisibleInLocalModule(File, M)) return false;
+ else PP.setIncludeVisibleForHeader(File, M);
+ } else {
----------------
jyknight wrote:
> I wonder if this should be just using the CurSubmoduleState. Actually, is "M"
> even needed in this function at all -- why isn't everything just using
> CurSubmoduleState? (It's very likely I'm just confused about what the
> semantics of this are...).
> "Is M needed ... ?"
Yes - I think so because if we're looking at Module header, then I *think* the
header's content will/should be visible to the submods in it.
On the other hand (ie., the else branch), if we're looking a "regular" header,
then it should not be visible to the submods
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
https://reviews.llvm.org/D75951
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
