JonChesterfield added a comment. In D74361#1920329 <https://reviews.llvm.org/D74361#1920329>, @aaron.ballman wrote:
> Aside from the diagnostic wording, I think this LG to me. However, I'd > appreciate if @rjmccall would also sign off. Thanks! @rjmccall? ================ Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5344 +def err_loader_uninitialized_extern_decl : Error< + "external declaration of variable cannot have the 'loader_uninitialized' attribute">; def err_block_extern_cant_init : Error< ---------------- aaron.ballman wrote: > How would you feel about: `"variable %0 cannot be declared both 'extern' and > with the 'loader_uninitialized' attribute"` (or something along those lines) > to clarify "external declaration"? Better, thanks. Also discovered clang-format has learned to do sensible things with tablegen so applied it to the new defs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74361/new/ https://reviews.llvm.org/D74361 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
