jdoerfert marked an inline comment as done. jdoerfert added inline comments.
BRANCHES master /clang/test/OpenMP/PR44893.c:3 > A test with no CHECK lines also passes if you symlink /bin/true to clang :-) > It also doesn't indicate what is being relevant and when it comes to > maintaining / updating the test we won't know what is important to keep. This is a common pattern, except the `%clang` part maybe. I'm fine with removing this test as the actual issue is covered explicitly, see below. This was added as the original reproducer, not the minimal one (which is IR). > The fact that there was a crash that wasn't hit by the test suite indicates > that there was some behavior that wasn't tested before, so we should really > try to check that behavior. > > Can you add some sort of positive test, related to where the crash was? > I did, in deduplication.ll. I did, in deduplication.ll Users: jdoerfert (Author) https://reviews.llvm.org/rG396b7253944e _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
