jdoerfert added a comment. I think this is functionally correct even if we pass the pointer for now as it is properly "privatized" in the callee.
I will go over this once more (after some sleep) but I think it is all good. Once @fghanim puts the new code path on phab we need to ensure it works well with this addition. In D75591#1904969 <https://reviews.llvm.org/D75591#1904969>, @lebedev.ri wrote: > IIUC `default(firstprivate)` is being added in openmp-5.1, > it is not in openmp-4.5, so it should not be accepted > in pre-openmp-5.1-mode (i.e. it should be diagnosed) @atmnpatel This is still an open issue, correct? Could you also mention again if and how we could implement `default(private)`, or what problems you envision? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
