Szelethus added a comment.
A few nits, otherwise the patch is great!
================
Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:519-520
+const NoteTag *IteratorModeling::getChangeTag(CheckerContext &C, StringRef
Text,
+ const Expr *ItE, SVal It1,
+ int64_t Amount, SVal It2) const {
+ StringRef Name;
----------------
Are `It1` and `It2` used? Why do we default the latter to `UndefinedVal`?
================
Comment at: clang/test/Analysis/iterator-modelling.cpp:1-5
+// RUN: %clang_analyze_cc1 -std=c++11
-analyzer-checker=core,cplusplus,debug.DebugIteratorModeling,debug.ExprInspection
-analyzer-config aggressive-binary-operation-simplification=true
-analyzer-config c++-container-inlining=false -analyzer-output=text %s -verify
-// RUN: %clang_analyze_cc1 -std=c++11
-analyzer-checker=core,cplusplus,debug.DebugIteratorModeling,debug.ExprInspection
-analyzer-config aggressive-binary-operation-simplification=true
-analyzer-config c++-container-inlining=true -DINLINE=1 %s -verify
+// RUN: %clang_analyze_cc1 -std=c++11
-analyzer-checker=core,cplusplus,debug.DebugIteratorModeling,debug.ExprInspection
-analyzer-config aggressive-binary-operation-simplification=true
-analyzer-config c++-container-inlining=true -DINLINE=1 -analyzer-output=text
%s -verify
// RUN: %clang_analyze_cc1 -std=c++11
-analyzer-checker=core,cplusplus,alpha.cplusplus.IteratorModeling,debug.ExprInspection
-analyzer-config aggressive-binary-operation-simplification=true %s 2>&1 |
FileCheck %s
----------------
Can we prettify this? :)
================
Comment at: clang/test/Analysis/iterator-range.cpp:1-2
-// RUN: %clang_analyze_cc1 -std=c++11
-analyzer-checker=core,cplusplus,alpha.cplusplus.IteratorRange -analyzer-config
aggressive-binary-operation-simplification=true -analyzer-config
c++-container-inlining=false %s -verify
-// RUN: %clang_analyze_cc1 -std=c++11
-analyzer-checker=core,cplusplus,alpha.cplusplus.IteratorRange -analyzer-config
aggressive-binary-operation-simplification=true -analyzer-config
c++-container-inlining=true -DINLINE=1 %s -verify
+// RUN: %clang_analyze_cc1 -std=c++11
-analyzer-checker=core,cplusplus,alpha.cplusplus.IteratorRange -analyzer-config
aggressive-binary-operation-simplification=true -analyzer-config
c++-container-inlining=false -analyzer-output=text %s -verify
+// RUN: %clang_analyze_cc1 -std=c++11
-analyzer-checker=core,cplusplus,alpha.cplusplus.IteratorRange -analyzer-config
aggressive-binary-operation-simplification=true -analyzer-config
c++-container-inlining=true -DINLINE=1 -analyzer-output=text %s -verify
----------------
And this?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74541/new/
https://reviews.llvm.org/D74541
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
