balazske added a comment.

What is better? Have this (or similar) change that adds a feature that is used 
in a later change and is only testable in that later change, or have a bigger 
change that contains real use of the added features? (This means: Add `fseek` 
to this change or not.) The error handling is not normally testable if there is 
no function that generates error state, `fseek` could be one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75682/new/

https://reviews.llvm.org/D75682



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to