sammccall added a comment.
Herald added a reviewer: jdoerfert.

So if I understand the history here:

- the `IsOMPStructuredBlock` bit on `Stmt` was added to implement 
`getStructuredBlock()`
- after review, `getStructuredBlock()` doesn't use the bit
- the bit is used in the textual AST dump, and an AST matcher (which is in turn 
never used in-tree)

Can we have the bit back please :-)
We're currently trying to add a HasErrors bit to improve error-recovery and 
some nodes are completely full.
Using a bit on every Stmt to improve the text dump a little and provide a 
matcher (only relevant to OMP files) seems disproportionately expensive.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59214/new/

https://reviews.llvm.org/D59214



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to