nridge marked an inline comment as done. nridge added inline comments.
================ Comment at: clang-tools-extra/clangd/XRefs.cpp:489 + Index->fuzzyFind(Req, [&](const Symbol &Sym) { + auto MaybeDeclLoc = + symbolLocationToLocation(Sym.CanonicalDeclaration, MainFilePath); ---------------- Sorry this location-setting code is so messy. All my attempts to make it more concise have been thwarted by `llvm::Expected`'s very restrictive API. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72874/new/ https://reviews.llvm.org/D72874 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits