balazske added inline comments.
================ Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:355 + template <bool ShouldFreeOnFail> + void checkRealloc(CheckerContext &C, const CallExpr *CE, + ProgramStateRef State) const; ---------------- The `CHECK_FN` could be used even here? ``` template <bool ShouldFreeOnFail> CHECK_FN(checkRealloc) ``` ================ Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:1184 + checkCXXNewOrCXXDelete(C, CE, State); + + checkOwnershipAttr(C, CE, State); ---------------- If these cases are exclusive the code looks better when `else` statements are added? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68165/new/ https://reviews.llvm.org/D68165 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
