erichkeane added inline comments.
================
Comment at: clang/lib/Sema/SemaType.cpp:2197-2198
+  if (NumBits > llvm::IntegerType::MAX_INT_BITS) {
+    Diag(Loc, diag::err_ext_int_max_size) << IsUnsigned
+                                         << llvm::IntegerType::MAX_INT_BITS;
+    return QualType();
----------------
aaron.ballman wrote:
> Formatting looks slightly off here (the indentation for the second trailing 
> argument looks funky, but maybe that's just Phab).
Strange... Doesn't show up that way in VIM.  I had to copy/paste this review 
from a file on a linux share out of Notepad++ into the editor because the patch 
size is larger than the 8MB Phab max, so I can imagine a space or two got lost 
in that translation :) 

My workspace copy is correct however.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73967/new/

https://reviews.llvm.org/D73967



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to