efriedma added a comment. Please update the documentation comment at the top of Builtins.def .
Can we avoid a gigantic, expensive to parse arm_sve.h somehow? Given that the compiler has to know the signatures for all these buitins anyway, can we just make including arm_sve.h set some flag in the compiler to make it recognize all the SVE intrinsics? This is different from the way we handle intrinsics on other targets, but SVE seems like a good opportunity to try a new approach. ================ Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:508 + std::max((uint64_t)LargestVectorWidth, + VT->getPrimitiveSizeInBits().getFixedSize()); ---------------- I'm not sure that we'll ever want to take advantage of min-legal-vector-width on targets with scalable vectors... but if we did, we'd probably want to use `getKnownMinSize()` here Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75298/new/ https://reviews.llvm.org/D75298 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
